sankarh commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID
tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r270911338
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -196,6 +196,11 @@ public static boolean shouldReplicate(ReplicationSpec
replicationSpec, Table tab
}
return shouldReplicateExternalTables;
}
+
+ // Skip dumping events related to ACID tables if bootstrap is enabled on
it
Review comment:
shouldReplicate is not checked by events such as AllocateWriteIdEvent and
CommitTxnEvent.
CommitTxnEvent cannot be skipped but need to remove all AcidWriteEvents
which are packed along with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
