sankarh commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID
tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275125959
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AllocWriteIdHandler.java
##########
@@ -35,6 +36,21 @@ AllocWriteIdMessage eventMessage(String
stringRepresentation) {
@Override
public void handle(Context withinContext) throws Exception {
LOG.info("Processing#{} ALLOC_WRITE_ID message : {}", fromEventId(),
eventMessageAsJSON);
+
+ // If we are bootstrapping ACID table during an incremental dump, the
events corresponding to
+ // these ACID tables are not dumped. Hence we do not need to allocate any
writeId on the
+ // target and hence we do not need to dump these events.
+ if
(withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES))
{
+ return;
+ }
+
+ // Also only for testing, we do not include ACID tables in the dump (and
replicate) if config
+ // says so.
+ if (withinContext.hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL)
&&
Review comment:
Need not check HIVE_IN_TEST_REPL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
