ashutosh-bapat commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID tables as part of incremental dump. URL: https://github.com/apache/hive/pull/581#discussion_r271382627
########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java ########## @@ -193,27 +226,39 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive dmd.setDump(DumpType.INCREMENTAL, work.eventFrom, lastReplId, cmRoot); dmd.write(); - // If external tables are enabled for replication and - // - If bootstrap is enabled, then need to combine bootstrap dump of external tables. - // - If metadata-only dump is enabled, then shall skip dumping external tables data locations to - // _external_tables_info file. If not metadata-only, then dump the data locations. - if (conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES) - && (!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY) - || conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_EXTERNAL_TABLES))) { + // Examine all the tables if required. + if (shouldExamineTablesToDump()) { Path dbRoot = getBootstrapDbRoot(dumpRoot, dbName, true); + + // If we are bootstrapping ACID tables, stop all the concurrent transactions and take a + // snapshot to dump those tables. Record the last event id in case we are performing + // bootstrap of ACID tables. + String validTxnList = null; + long bootstrapLastReplId = 0; + if (conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)) { + validTxnList = getValidTxnListForReplDump(hiveDb); + bootstrapLastReplId = hiveDb.getMSC().getCurrentNotificationEventId().getEventId(); Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org