ashutosh-bapat commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID tables as part of incremental dump. URL: https://github.com/apache/hive/pull/581#discussion_r271391544
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java ########## @@ -196,6 +196,11 @@ public static boolean shouldReplicate(ReplicationSpec replicationSpec, Table tab } return shouldReplicateExternalTables; } + + // Skip dumping events related to ACID tables if bootstrap is enabled on it Review comment: Do you mean WriteEventInfo instead of AcidWriteEvents? I believe CommitTxnEvent can contain only write events for ACID tables. So writeEventInfoList in CommitTxnHandler.handle() should be set to null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org