maheshk114 commented on a change in pull request #588: HIVE-20968 : Support conversion of managed to external where location set was not owned by hive URL: https://github.com/apache/hive/pull/588#discussion_r273442880
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java ########## @@ -300,10 +300,10 @@ public static void createExportDump(FileSystem fs, Path metadataPath, Table tabl } try (JsonWriter writer = new JsonWriter(fs, metadataPath)) { + new TableSerializer(tableHandle, partitions, hiveConf).writeTo(writer, replicationSpec); Review comment: replication spec is modified in the serializer to avoid iterating over the partitions again. So replication spec dump is moved down. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org