maheshk114 commented on a change in pull request #588: HIVE-20968 : Support 
conversion of managed to external where location set was not owned by hive
URL: https://github.com/apache/hive/pull/588#discussion_r273443465
 
 

 ##########
 File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
 ##########
 @@ -40,6 +42,11 @@ public AlterTableEvent (Table oldTable, Table newTable, 
boolean isTruncateOp, bo
     this.newTable = newTable;
     this.isTruncateOp = isTruncateOp;
     this.writeId = writeId;
+    if (newTable.getSd() == null) {
 
 Review comment:
   not sure ..if the location is not changed ..then it make sense to keep it 
null ..to avoid extra data to be written to meta store db 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to