sankarh commented on a change in pull request #591: HIVE-21500: Disable
conversion of managed table to external and vice versa at source.
URL: https://github.com/apache/hive/pull/591#discussion_r274570834
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/HiveStrictManagedUtils.java
##########
@@ -59,6 +59,10 @@ public static String
validateStrictManagedTable(Configuration conf,
if (isAvroTableWithExternalSchema(table)) {
return createValidationError(table, "Managed Avro table has
externally defined schema.");
}
+ } else if (tableType == TableType.EXTERNAL_TABLE) {
+ if (MetaStoreServerUtils.isTransactionalTable(table.getParameters())) {
+ return createValidationError(table, "Table is marked as a external
table but it is transactional.");
+ }
Review comment:
It is not in the scope of this patch. This patch focus on alter to/from
external. I assume, create case was already tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
