sankarh commented on a change in pull request #591: HIVE-21500: Disable
conversion of managed table to external and vice versa at source.
URL: https://github.com/apache/hive/pull/591#discussion_r274574728
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
##########
@@ -803,6 +805,22 @@ public Partition alterPartition(RawStore msdb, Warehouse
wh, String catName, Str
return oldParts;
}
+ private void checkTableTypeConversion(Database db, Table oldTbl, Table
newTbl)
Review comment:
If we restrict only managed to external and external to managed conversion,
then the new type introduced in future might break replication. So, we cannot
guarantee it.
I think, it is better to restrict any table type conversion. Maybe, in the
comment, I will add this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
