sankarh commented on a change in pull request #581: HIVE-21529 : Bootstrap ACID 
tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275125931
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
 ##########
 @@ -196,6 +196,23 @@ public static boolean shouldReplicate(ReplicationSpec 
replicationSpec, Table tab
         }
         return shouldReplicateExternalTables;
       }
+
+      if (AcidUtils.isTransactionalTable(tableHandle.getTTable())) {
+        // For testing purposes only, do not replicate ACID tables when config 
says so
+        boolean shouldReplicateAcidTables = true;
+        if (hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL)) {
 
 Review comment:
   Need not check HIVE_IN_TEST_REPL anywhere. Let's have the proper support of 
REPL_DUMP_INCLUDE_ACID_TABLES flag.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to