sankarh commented on a change in pull request #591: HIVE-21500: Disable
conversion of managed table to external and vice versa at source.
URL: https://github.com/apache/hive/pull/591#discussion_r275142605
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java
##########
@@ -146,6 +146,12 @@ private void
handleAlterTableTransactionalProp(PreAlterTableEvent context) throw
}
if (transactionalValuePresent) {
+ if (oldTable.getTableType().equals(TableType.MANAGED_TABLE.toString())
+ &&
newTable.getTableType().equals(TableType.EXTERNAL_TABLE.toString())) {
Review comment:
In fact, this code handles both conversion. If transactional key(not value)
exist, it reaches this flow. So, it handles conversion from old transactional
managed table to be converted to non-transactional external table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
