vineetgarg02 commented on a change in pull request #656: HIVE-21742 :
Vectorization: CASE result type casting
URL: https://github.com/apache/hive/pull/656#discussion_r290015489
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
##########
@@ -1274,6 +1274,40 @@ protected ExprNodeDesc
getXpathOrFuncExprNodeDesc(ASTNode expr,
children);
}
+ // introduce cast for expressions which are of different type than
parent WHEN expr's type
Review comment:
WHEN here refers to the whole expression (instead of WHEN branch). I'll
update the comment to make it more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
