vineetgarg02 commented on a change in pull request #656: HIVE-21742 : 
Vectorization: CASE result type casting
URL: https://github.com/apache/hive/pull/656#discussion_r290516708
 
 

 ##########
 File path: 
ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out
 ##########
 @@ -73,7 +73,7 @@ STAGE PLANS:
                 outputColumnNames: _col0, _col1, _col2, _col3
                 Statistics: Num rows: 18 Data size: 1628 Basic stats: COMPLETE 
Column stats: COMPLETE
                 Select Operator
-                  expressions: CASE WHEN (((_col3 = 3L) and _col0 is not 
null)) THEN (1) ELSE (null) END (type: int), CASE WHEN (((_col3 = 5L) and _col1 
is not null)) THEN (1) ELSE (null) END (type: int), CASE WHEN (((_col3 = 6L) 
and _col2 is not null)) THEN (1) ELSE (null) END (type: int)
+                  expressions: CASE WHEN (((_col3 = 3L) and _col0 is not 
null)) THEN (1) ELSE (UDFToInteger(null)) END (type: int), CASE WHEN (((_col3 = 
5L) and _col1 is not null)) THEN (1) ELSE (UDFToInteger(null)) END (type: int), 
CASE WHEN (((_col3 = 6L) and _col2 is not null)) THEN (1) ELSE 
(UDFToInteger(null)) END (type: int)
 
 Review comment:
   Latest update fixes constant folding issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to