ashutosh-bapat commented on a change in pull request #684: HIVE-21880 : Enable
flaky test
TestReplicationScenariosAcidTablesBootstrap.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites.
URL: https://github.com/apache/hive/pull/684#discussion_r299310307
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -997,6 +998,15 @@ private void addNotificationLog(NotificationEvent event,
ListenerEvent listenerE
stmt.execute("SET @@session.sql_mode=ANSI_QUOTES");
}
+ // Derby doesn't allow FOR UPDATE to lock the row being selected (See
https://db.apache
+ // .org/derby/docs/10.1/ref/rrefsqlj31783.html) . So lock the whole
table. Since there's
+ // only one row in the table, this shouldn't cause any performance
degradation. Also we not
+ // suggest Derby to be used in production so that's fine.
+ if (sqlGenerator.getDbProduct() == DatabaseProduct.DERBY) {
+ String lockingQuery = "lock table \"NOTIFICATION_SEQUENCE\" in
exclusive mode";
+ LOG.info("Going to execute query <" + lockingQuery + ">");
+ stmt.executeUpdate(lockingQuery);
+ }
String s = sqlGenerator.addForUpdateClause("select \"NEXT_EVENT_ID\" " +
Review comment:
sqlGenerator.addForUpdateClause() does not add FOR UPDATE clause for Derby,
so effect is same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
