ashutosh-bapat commented on a change in pull request #684: HIVE-21880 : Enable
flaky test
TestReplicationScenariosAcidTablesBootstrap.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites.
URL: https://github.com/apache/hive/pull/684#discussion_r299329321
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -997,6 +998,15 @@ private void addNotificationLog(NotificationEvent event,
ListenerEvent listenerE
stmt.execute("SET @@session.sql_mode=ANSI_QUOTES");
}
+ // Derby doesn't allow FOR UPDATE to lock the row being selected (See
https://db.apache
Review comment:
The callers of ObjectStore#addNotificationEvents() will not take derbyLock
and thus they will be able to access NOTIFICATION_SEQUENCE while the txnHandler
callers are accessing it. We need same synchronization in both the methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
