sankarh commented on a change in pull request #705: HIVE-21958 : The list of table expression in the inclusion and exclusion list should be separated by '|' instead of comma. URL: https://github.com/apache/hive/pull/705#discussion_r300937934
########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/repl/ReplScope.java ########## @@ -31,10 +29,10 @@ private Pattern dbNamePattern; // Include and exclude table names/patterns exist only for REPL DUMP. - private List<String> includedTableNames; - private List<String> excludedTableNames; - private List<Pattern> includedTableNamePatterns; - private List<Pattern> excludedTableNamePatterns; + private String includedTableNames; + private String excludedTableNames; + private Pattern includedTableNamePatterns; Review comment: Name can be includedTableNamesPattern and excludedTableNamesPattern as it is single pattern. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
