sankarh commented on a change in pull request #705: HIVE-21958 : The list of
table expression in the inclusion and exclusion list should be separated by '|'
instead of comma.
URL: https://github.com/apache/hive/pull/705#discussion_r300961527
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTableLevelReplicationScenarios.java
##########
@@ -263,12 +263,12 @@ public void testIncorrectTablePolicyInReplDump() throws
Throwable {
String[] replicatedTables = new String[] {};
boolean failed;
String[] invalidReplPolicies = new String[] {
- primaryDbName + ".t1.t2", // Two explicit table names not allowed.
- primaryDbName + ".['t1'].t2", // Table name and include list not
allowed.
- primaryDbName + ".t1.['t2']", // Table name and exclude list not
allowed.
- primaryDbName + ".[t1].t2", // Table name and include list not allowed.
- primaryDbName + ".['t1+'].", // Abrubtly ended dot.
- primaryDbName + "..[]" // Multiple dots
+ primaryDbName + ".t1.t2", // Didn't enclose table pattern within
single quotes.
+ primaryDbName + ".'t1'.t2", // Table name and include list not allowed.
+ primaryDbName + ".t1.'t2'", // Table name and exclude list not allowed.
+ primaryDbName + ".'t1+'.", // Abrubtly ended dot.
Review comment:
We can add the empty include/exclude list in this test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
