vineetgarg02 commented on a change in pull request #729: HIVE-22003
URL: https://github.com/apache/hive/pull/729#discussion_r306066881
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##########
@@ -486,6 +510,75 @@ private static boolean
sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
return mergedExecuted;
}
+ private static void replaceSemijoinExpressions(TableScanOperator tsOp,
List<ExprNodeDesc> semijoinExprNodes) {
Review comment:
If I understand this correctly this is suppose to remove all semijoin
related expressions from TS as well as its children filter op. Why is this
method taking `retainableTsOp's` `semijoinExprNodes`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
