vineetgarg02 commented on a change in pull request #729: HIVE-22003
URL: https://github.com/apache/hive/pull/729#discussion_r306073523
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
 ##########
 @@ -486,6 +510,75 @@ private static boolean 
sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
     return mergedExecuted;
   }
 
+  private static void replaceSemijoinExpressions(TableScanOperator tsOp, 
List<ExprNodeDesc> semijoinExprNodes) {
 
 Review comment:
   So the SJ branch from retainable TS is pushed to discardable TS  so that it 
is later pushed to discardable TS's children filter op? Why do we want to do 
that? Shouldn't retainable SJ be retained with retainable FILTER op only? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to