jcamachor commented on a change in pull request #733: HIVE-12971: Add Support
for Kudu Tables
URL: https://github.com/apache/hive/pull/733#discussion_r306130094
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -778,4 +778,27 @@ public MiniDruidLlapLocalCliConfig() {
}
}
+ /**
+ * The CliConfig implementation for Kudu.
+ */
+ public static class KuduCliConfig extends AbstractCliConfig {
+ public KuduCliConfig() {
+ super(CoreKuduCliDriver.class);
+ try {
+ setQueryDir("kudu-handler/src/test/queries/positive");
+
+ setResultsDir("kudu-handler/src/test/results/positive");
+ setLogDir("itests/qtest/target/qfile-results/kudu-handler/positive");
+
+ setInitScript("q_test_init_src.sql");
+ setCleanupScript("q_test_cleanup_src.sql");
+
+ setHiveConfDir("");
+ setClusterType(MiniClusterType.NONE);
Review comment:
Cluster type `NONE` seems to be `MR`.
We should probably create a type `KUDU_LOCAL`, e.g., similar to
`DRUID_LOCAL` (see `MiniDruidLlapLocalCliConfig` in `CliConfigs`). That would
be useful to test Kudu with LLAP, in addition tests will run faster, etc.
Can you try to change it? If you find any major issues, please create a
follow-up JIRA for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
