jcamachor commented on a change in pull request #733: HIVE-12971: Add Support 
for Kudu Tables
URL: https://github.com/apache/hive/pull/733#discussion_r306132891
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -2900,6 +2900,11 @@ private static void 
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
     HIVE_HBASE_SNAPSHOT_RESTORE_DIR("hive.hbase.snapshot.restoredir", "/tmp", 
"The directory in which to " +
         "restore the HBase table snapshot."),
 
+    // For Kudu storage handler
+    HIVE_KUDU_MASTER_ADDRESSES_DEFAULT("hive.kudu.master.addresses.default", 
"localhost:7050",
 
 Review comment:
   If I understand correctly from `KuduHiveUtils.getMasterAddresses` code 
below, this is only used if the master addresses are not specified via table 
properties for a given table. Can you validate this assumption? If that is the 
case, please update parameter description accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to