sankarh commented on a change in pull request #742: HIVE-22068 : Add more logging to notification cleaner and replication to track events URL: https://github.com/apache/hive/pull/742#discussion_r314596061
########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java ########## @@ -750,6 +766,38 @@ public Table apply(@Nullable Table table) { .verifyResults(Arrays.asList("1", "2")); } + @Test + public void testIncrementalDumpEmptyDumpDirectory() throws Throwable { Review comment: Add another test case where we dynamically bootstrap a table (table level replication) with incremental dump but no events are dumped. It takes a special route in executeIncrementalLoad() method Line: 503 and so I guess, as per current change, it won't update the database last repl ID. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org