sankarh commented on a change in pull request #742: HIVE-22068 : Add more 
logging to notification cleaner and replication to track events
URL: https://github.com/apache/hive/pull/742#discussion_r314934579
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
 ##########
 @@ -522,6 +525,25 @@ private int executeIncrementalLoad(DriverContext 
driverContext) {
       // bootstrap of tables if exist.
       if (builder.hasMoreWork() || work.getPathsToCopyIterator().hasNext() || 
work.hasBootstrapLoadTasks()) {
         DAGTraversal.traverse(childTasks, new 
AddDependencyToLeaves(TaskFactory.get(work, conf)));
+      } else if (work.dbNameToLoadIn != null) {
+        // Nothing to be done for repl load now. Add a task to update the 
last.repl.id of the
+        // target database to the event id of the last event considered by the 
dump. Next
+        // incremental cycle if starts from this id, the events considered for 
this dump, won't
+        // be considered again. If we are replicating to multiple databases at 
a time, it's not
+        // possible to know which all databases we are replicating into and 
hence we can not
+        // update repl id in all those databases.
+        String lastEventid = builder.eventTo().toString();
 
 Review comment:
   OK
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to