jcamachor commented on a change in pull request #780: HIVE-22079: Post order
walker for iterating over expression tree
URL: https://github.com/apache/hive/pull/780#discussion_r327439736
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lib/ExpressionWalker.java
##########
@@ -35,63 +40,69 @@ public ExpressionWalker(Dispatcher disp) {
}
- /**
- * We should bypass subquery since we have already processed and created
logical plan
- * (in genLogicalPlan) for subquery at this point.
- * SubQueryExprProcessor will use generated plan and creates appropriate
ExprNodeSubQueryDesc.
- */
- private boolean shouldByPass(Node childNode, Node parentNode) {
- if(parentNode instanceof ASTNode
- && ((ASTNode)parentNode).getType() ==
HiveParser.TOK_SUBQUERY_EXPR) {
- ASTNode parentOp = (ASTNode)parentNode;
- //subquery either in WHERE <LHS> IN <SUBQUERY> form OR WHERE EXISTS
<SUBQUERY> form
- //in first case LHS should not be bypassed
- assert(parentOp.getChildCount() == 2 || parentOp.getChildCount()==3);
- if(parentOp.getChildCount() == 3 && (ASTNode)childNode ==
parentOp.getChild(2)) {
- return false;
- }
- return true;
+ private class NodeLabeled {
+ private Node nd;
Review comment:
`final`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
