jcamachor commented on a change in pull request #780: HIVE-22079: Post order
walker for iterating over expression tree
URL: https://github.com/apache/hive/pull/780#discussion_r327439189
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lib/ExpressionWalker.java
##########
@@ -18,11 +18,16 @@
package org.apache.hadoop.hive.ql.lib;
-import org.apache.hadoop.hive.ql.parse.ASTNode;
-import org.apache.hadoop.hive.ql.parse.HiveParser;
import org.apache.hadoop.hive.ql.parse.SemanticException;
-public class ExpressionWalker extends DefaultGraphWalker {
+import java.util.Stack;
Review comment:
Consider using `Deque/ArrayDeque` instead, since its usage is recommended
over `Stack` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
