jcamachor commented on a change in pull request #801: HIVE-22248 Fix statistics
persisting issues
URL: https://github.com/apache/hive/pull/801#discussion_r330829541
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/merge/DoubleColumnStatsMerger.java
##########
@@ -50,5 +50,16 @@ public void merge(ColumnStatisticsObj aggregateColStats,
ColumnStatisticsObj new
+ aggregateData.getNumDVs() + " and " + newData.getNumDVs() + " to
be " + ndv);
aggregateData.setNumDVs(ndv);
}
+
+ aggregateColStats.getStatsData().setDoubleStats(aggregateData);
+ }
+
+ private double getMinValue(DoubleColumnStatsDataInspector aggregateData,
DoubleColumnStatsDataInspector newData) {
+ if (!aggregateData.isSetLowValue() && !newData.isSetLowValue()) {
+ return 0;
Review comment:
If they are both unset, why do we return `0` here instead of leaving it
unset? I am not sure whether this will ever happen, but it seems the right
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
