jcamachor commented on a change in pull request #801: HIVE-22248 Fix statistics
persisting issues
URL: https://github.com/apache/hive/pull/801#discussion_r331155774
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/merge/DoubleColumnStatsMerger.java
##########
@@ -30,7 +30,7 @@
public void merge(ColumnStatisticsObj aggregateColStats, ColumnStatisticsObj
newColStats) {
DoubleColumnStatsDataInspector aggregateData =
doubleInspectorFromStats(aggregateColStats);
DoubleColumnStatsDataInspector newData =
doubleInspectorFromStats(newColStats);
- aggregateData.setLowValue(Math.min(aggregateData.getLowValue(),
newData.getLowValue()));
+ setMinValue(aggregateData, newData);
aggregateData.setHighValue(Math.max(aggregateData.getHighValue(),
newData.getHighValue()));
Review comment:
Should we do the same for high value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
