jcamachor commented on a change in pull request #787: HIVE-22239
URL: https://github.com/apache/hive/pull/787#discussion_r332991505
 
 

 ##########
 File path: 
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
 ##########
 @@ -562,14 +562,27 @@ struct DateColumnStatsData {
 5: optional binary bitVectors
 }
 
+struct Timestamp {
+1: required i64 secondsSinceEpoch
 
 Review comment:
   I do not think it is too complicated but it will imply changes in the 
metastore tables that store these values too. I did not want to change the 
internal representation of column stats for timestamp type in this patch, that 
is why I introduced the type but did not change the internal representation 
based on seconds. I created https://issues.apache.org/jira/browse/HIVE-22309.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to