jcamachor commented on a change in pull request #843: HIVE-22488 Break up DDLSemanticAnalyzer - extract Table creation analyzers URL: https://github.com/apache/hive/pull/843#discussion_r348849492
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/createlike/CreateTableLikeDesc.java ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.hadoop.hive.ql.ddl.table.creation; Review comment: Instead of `org.apache.hadoop.hive.ql.ddl.table.creation.create` or `org.apache.hadoop.hive.ql.ddl.table.creation.drop`, isn't it more natural to have `org.apache.hadoop.hive.ql.ddl.table.create` or `org.apache.hadoop.hive.ql.ddl.table.drop`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
