jcamachor commented on a change in pull request #843: HIVE-22488 Break up DDLSemanticAnalyzer - extract Table creation analyzers URL: https://github.com/apache/hive/pull/843#discussion_r350513931
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/createlike/CreateTableLikeDesc.java ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.hadoop.hive.ql.ddl.table.creation; Review comment: Yes, I believe having `create` or `drop` packages within `table` package, even if we have them next to `column`, `constraint`, etc., is more intuitive. It seems the additional subpackage does not provide clarity, e.g., `creation.drop` or `creation.create` is confusing. Also the `creation` package seem small enough already, hence another option is that these classes go directly to the `table` package. I believe there are many options, right now it is a matter of taste... I would just avoid redundant packages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
