t3rmin4t0r commented on a change in pull request #856: HIVE-22463 decimal64
multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558668
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
##########
@@ -3398,7 +3408,8 @@ private VectorExpression
tryDecimal64Between(VectorExpressionDescriptor.Mode mod
cl, childrenAfterNot, VectorExpressionDescriptor.Mode.PROJECTION,
/* isDecimal64ScaleEstablished */ true,
/* decimal64ColumnScale */ ((DecimalTypeInfo)
colExpr.getTypeInfo()).getScale(),
- returnTypeInfo, DataTypePhysicalVariation.NONE);
+ returnTypeInfo, DataTypePhysicalVariation.NONE,
+ /* dontRescaleArguments */ false);
Review comment:
with the comment that does look very odd - "don't = false"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
