t3rmin4t0r commented on a change in pull request #856: HIVE-22463 decimal64
multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558504
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
##########
@@ -286,19 +292,24 @@ public boolean matches(Descriptor other) {
return false;
}
}
+ if (unscaled != other.unscaled) {
+ return false;
+ }
return true;
}
private final Mode mode;
private final ArgumentType [] argTypes;
private final InputExpressionType [] exprTypes;
private final int argCount;
+ private boolean unscaled;
Review comment:
The build has non-finals, but the actual class has all finals (that's a good
convention)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
