aasha commented on a change in pull request #900: HIVE-22860 Support metadata
only replication for external tables
URL: https://github.com/apache/hive/pull/900#discussion_r378400562
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -172,7 +172,8 @@ private boolean shouldExamineTablesToDump() {
*/
private boolean shouldDumpExternalTableLocation() {
return conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
- && !conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY);
+ && (!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY) &&
Review comment:
Then they will set REPL_INCLUDE_EXTERNAL_TABLES to true,
REPL_DUMP_METADATA_ONLY and REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to
false.
If they set REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to true and
REPL_DUMP_METADATA_ONLY to false, then managed table data + metadata will be
dumped, but external table metadata only.
If they set REPL_DUMP_METADATA_ONLY_FOR_EXTERNAL_TABLE to false but
REPL_DUMP_METADATA_ONLY to true then only metadata will be dumped for both
external and managed tables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
