maheshk114 commented on a change in pull request #900: HIVE-22860 Support
metadata only replication for external tables
URL: https://github.com/apache/hive/pull/900#discussion_r379991400
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -493,7 +494,8 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
Exception caught = null;
boolean shouldWriteExternalTableLocationInfo =
conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
- &&
!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY);
+ &&
(!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY) &&
Review comment:
why not use shouldDumpExternalTableLocation to check ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
