pkumarsinha commented on a change in pull request #911: HIVE-22865 Include data
in replication staging directory
URL: https://github.com/apache/hive/pull/911#discussion_r386348059
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -582,10 +586,19 @@ void dumpTable(String dbName, String tblName, String
validTxnList, Path dbRoot,
}
MmContext mmCtx = MmContext.createIfNeeded(tableSpec.tableHandle);
tuple.replicationSpec.setRepl(true);
- new TableExport(
- exportPaths, tableSpec, tuple.replicationSpec, hiveDb, distCpDoAsUser,
conf, mmCtx).write();
-
+ List<ReplPathMapping> replPathMappings = new TableExport(
+ exportPaths, tableSpec, tuple.replicationSpec, hiveDb,
distCpDoAsUser, conf, mmCtx).write(false);
replLogger.tableLog(tblName, tableSpec.tableHandle.getTableType());
+ if (Utils.shouldDumpMetaDataOnly(tuple.object, conf)) {
Review comment:
No, it is not done at this level. The checks have been done inside some
other method calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
