pkumarsinha commented on a change in pull request #911: HIVE-22865 Include data
in replication staging directory
URL: https://github.com/apache/hive/pull/911#discussion_r388480128
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
##########
@@ -904,8 +901,20 @@ public void replicationWithTableNameContainsKeywords()
throws Throwable {
return
ReplicationTestUtils.externalTableBasePathWithClause(REPLICA_EXTERNAL_BASE,
replica);
}
- private void assertExternalFileInfo(List<String> expected, Path
externalTableInfoFile)
+ private void assertExternalFileInfo(List<String> expected, String
dumplocation) throws IOException {
+ assertExternalFileInfo(expected, dumplocation, null);
+ }
+ private void assertExternalFileInfo(List<String> expected, String
dumplocation, String dbName)
throws IOException {
+ Path externalTableInfoFile = new Path(dumplocation,
relativeExtInfoPath(dbName));
ReplicationTestUtils.assertExternalFileInfo(primary, expected,
externalTableInfoFile);
}
+ private String relativeExtInfoPath(String dbName) {
+
+ if (dbName == null) {
Review comment:
No, the location of external table info file is different in bootstrap and
incremental case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
