davidov541 commented on a change in pull request #933: HIVE-21218: Adding
support for Confluent Kafka Avro message format
URL: https://github.com/apache/hive/pull/933#discussion_r387864743
##########
File path: kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java
##########
@@ -133,12 +134,40 @@
Preconditions.checkArgument(!schemaFromProperty.isEmpty(), "Avro Schema
is empty Can not go further");
Schema schema = AvroSerdeUtils.getSchemaFor(schemaFromProperty);
LOG.debug("Building Avro Reader with schema {}", schemaFromProperty);
- bytesConverter = new AvroBytesConverter(schema);
+ bytesConverter = getByteConverterForAvroDelegate(schema, tbl);
} else {
bytesConverter = new BytesWritableConverter();
}
}
+ enum BytesConverterType {
+ CONFLUENT,
Review comment:
As long as we document it very well, I'm fine with that. I understand your
thought process there, and it makes perfect sense. I'm also worried about
developers who use Confluent not realizing that they need to skip bytes, so
this is the value for them. It wouldn't be obvious if you are working with
Confluent that you actually need to skip some bytes. Perhaps we can add some
documentation on the Hive Confluence somewhere obvious stating this (not just
as part of the documentation for this particular value).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
