cricket007 commented on a change in pull request #933: HIVE-21218: Adding support for Confluent Kafka Avro message format URL: https://github.com/apache/hive/pull/933#discussion_r387867610
########## File path: kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java ########## @@ -369,6 +402,26 @@ private SubStructObjectInspector(StructObjectInspector baseOI, int toIndex) { } } + /** + * The converter reads bytes from kafka message and skip first @skipBytes from beginning. + * + * For example: + * Confluent kafka producer add 5 magic bytes that represents Schema ID as Integer to the message. Review comment: Nit: Confluent doesn't have its own version of a Kafka Producer. Its the Avro serializer that adds the bytes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org