b-slim commented on a change in pull request #933: HIVE-21218: Adding support
for Confluent Kafka Avro message format
URL: https://github.com/apache/hive/pull/933#discussion_r387888277
##########
File path: kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java
##########
@@ -133,12 +134,40 @@
Preconditions.checkArgument(!schemaFromProperty.isEmpty(), "Avro Schema
is empty Can not go further");
Schema schema = AvroSerdeUtils.getSchemaFor(schemaFromProperty);
LOG.debug("Building Avro Reader with schema {}", schemaFromProperty);
- bytesConverter = new AvroBytesConverter(schema);
+ bytesConverter = getByteConverterForAvroDelegate(schema, tbl);
} else {
bytesConverter = new BytesWritableConverter();
}
}
+ enum BytesConverterType {
+ CONFLUENT,
+ SKIP,
+ NONE;
+
+ static BytesConverterType fromString(String value) {
+ try {
+ return BytesConverterType.valueOf(value.trim().toUpperCase());
+ } catch (Exception e){
+ return NONE;
+ }
+ }
+ }
+
+ BytesConverter getByteConverterForAvroDelegate(Schema schema, Properties
tbl) {
+ String avroBytesConverterProperty = tbl.getProperty(AvroSerdeUtils
+
.AvroTableProperties.AVRO_SERDE_TYPE
+ .getPropName(),
BytesConverterType.NONE.toString());
+ BytesConverterType avroByteConverterType =
BytesConverterType.fromString(avroBytesConverterProperty);
+ Integer avroSkipBytes =
Integer.getInteger(tbl.getProperty(AvroSerdeUtils.AvroTableProperties.AVRO_SERDE_SKIP_BYTES
Review comment:
FYI the goal of code review is not to tell devs what to do, but to help them
understand why the code need to be changed ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
