maheshk114 commented on a change in pull request #949: HIVE-22990 Add file
based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392772991
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -146,7 +146,7 @@ public int execute() {
}
prepareReturnValues(Arrays.asList(currentDumpPath.toUri().toString(),
String.valueOf(lastReplId)));
writeDumpCompleteAck(hiveDumpRoot);
- deletePreviousDumpMeta(previousDumpMetaPath);
+ deleteAllPreviousDumpMeta(dumpRoot, currentDumpPath);
Review comment:
As load and dump are operating on same path ..how will it behave when load
is reading these dump directory while dump is reading it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
