aasha commented on a change in pull request #949: HIVE-22990 Add file based ack
for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392847438
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -168,6 +185,42 @@ private Long getEventFromPreviousDumpMetadata(Path
dumpRoot) throws IOException,
return 0L;
}
+ private Path getPreviousDumpMetadataPath(Path dumpRoot) throws IOException {
+ FileSystem fs = dumpRoot.getFileSystem(conf);
+ if (fs.exists(dumpRoot)) {
+ FileStatus[] statuses = fs.listStatus(dumpRoot);
+ if (statuses.length > 0) {
+ FileStatus latestUpdatedStatus = statuses[0];
+ for (FileStatus status : statuses) {
+ if (status.getModificationTime() >
latestUpdatedStatus.getModificationTime()) {
+ latestUpdatedStatus = status;
+ }
+ }
+ return latestUpdatedStatus.getPath();
+ }
+ }
+ return null;
+ }
+
+ private boolean shouldDump(Path previousDumpPath) throws IOException {
+ //If no previous dump means bootstrap. So return true as there was no
+ //previous dump to load
+ if (previousDumpPath == null) {
+ return true;
+ } else {
+ FileSystem fs = previousDumpPath.getFileSystem(conf);
+ if (fs.exists(previousDumpPath)) {
Review comment:
yes will update that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
