pkumarsinha commented on a change in pull request #949: HIVE-22990 Add file
based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393780762
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -398,6 +319,21 @@ private void dropTablesExcludedInReplScope(ReplScope
replScope) throws HiveExcep
dbName);
}
+ private void createReplLoadCompleteAckTask() {
+ if ((work.isIncrementalLoad() &&
!work.incrementalLoadTasksBuilder().hasMoreWork() &&
!work.hasBootstrapLoadTasks())
+ || (!work.isIncrementalLoad() && !work.hasBootstrapLoadTasks())) {
+ //All repl load tasks are executed and status is 0, create the task to
add the acknowledgement
+ ReplLoadCompleteAckWork replLoadCompleteAckWork = new
ReplLoadCompleteAckWork(work.dumpDirectory);
+ Task<ReplLoadCompleteAckWork> loadCompleteAckWorkTask =
TaskFactory.get(replLoadCompleteAckWork, conf);
+ if (this.childTasks.isEmpty()) {
Review comment:
Isn't childTask null sometime?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
