jcamachor commented on a change in pull request #970: Hive 23100
URL: https://github.com/apache/hive/pull/970#discussion_r409943454
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java
##########
@@ -183,11 +183,11 @@ public void testBreakupAnd2() throws ParseException,
CommandProcessorException {
List<FilterOperator> fos = pm.getAll(FilterOperator.class);
OpTreeSignature filterSig = pm.lookup(OpTreeSignature.class, fos.get(0));
Object pred = filterSig.getSig().getSigMap().get("getPredicateString");
- assertEquals("(u = 2) (type: boolean)", pred);
-
+ // TODO: Missed opportunity due to cast on constant preventing
simplification.
+ // Fixed when we upgrade to Calcite 1.22.0
+ assertEquals("((u = 2) and (u) IN (1, 2, 3)) (type: boolean)", pred);
Review comment:
Yes, when I saw this change the first time, I thought I would have to extend
Calcite logic to simplify this. Then I realized it was simplifying it in 1.22.
The culprit seems to be https://issues.apache.org/jira/browse/CALCITE-3525.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
