jcamachor commented on a change in pull request #970: Hive 23100
URL: https://github.com/apache/hive/pull/970#discussion_r409947154
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterSortPredicates.java
##########
@@ -223,7 +224,13 @@ public Double visitCall(RexCall call) {
return null;
}
cost += operandCost;
- Double size = HiveRelMdSize.averageTypeSize(operand.getType());
Review comment:
Yeah... The reason why I have it in this patch is that a lot of q files were
changing too without it. It seems the main reason is the subtle changes in the
handling of char, varchar, and string which lead to different ordering.
I could definitely create a new issue for this, but given that it will not
reduce the number of q file changes and that the method `typeValueSize` is part
of Calcite, could we include it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
