kasakrisz commented on a change in pull request #1131:
URL: https://github.com/apache/hive/pull/1131#discussion_r441503698
##########
File path: ql/src/test/results/clientpositive/llap/order_null.q.out
##########
@@ -116,12 +116,12 @@ POSTHOOK: query: SELECT x.* FROM src_null_n1 x ORDER BY b
desc, a asc
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src_null_n1
#### A masked pattern was here ####
-2 B
-1 A
-2 A
2 NULL
3 NULL
NULL NULL
+2 B
+1 A
+2 A
Review comment:
Not sure about how up-to-date that document is but as far as I know we
want nulls last as the default for asc and nulls first for desc.
It can be controlled by the setting `hive.default.nulls.last`. Default value
is `true`.
I also run these queries with Postgres and got the same results as with this
patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
