zabetak commented on a change in pull request #1131:
URL: https://github.com/apache/hive/pull/1131#discussion_r441509021
##########
File path: ql/src/test/results/clientpositive/llap/order_null.q.out
##########
@@ -116,12 +116,12 @@ POSTHOOK: query: SELECT x.* FROM src_null_n1 x ORDER BY b
desc, a asc
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src_null_n1
#### A masked pattern was here ####
-2 B
-1 A
-2 A
2 NULL
3 NULL
NULL NULL
+2 B
+1 A
+2 A
Review comment:
OK, now I understand better, thanks for the clarification.
The `hive.default.nulls.last` is a bit confusing. From the name and
description I get the impression that NULLS LAST is the default behavior for
both ASC and DESC and apparently it is not the case either.
Yes the new results are in sync with Postgres since the latter uses the
[semantics that you
mentioned](https://www.postgresql.org/docs/12/queries-order.html). Note that
this is not a rule from every DBMS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
