kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r445732481



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -2605,11 +2632,11 @@ public static Path getVersionFilePath(Path deltaOrBase) 
{
   public static List<FileStatus> getAcidFilesForStats(
       Table table, Path dir, Configuration jc, FileSystem fs) throws 
IOException {
     List<FileStatus> fileList = new ArrayList<>();
-    ValidWriteIdList idList = AcidUtils.getTableValidWriteIdList(jc,
+    org.apache.hadoop.hive.common.ValidWriteIdList idList = 
AcidUtils.getTableValidWriteIdList(jc,

Review comment:
       No

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -2605,11 +2632,11 @@ public static Path getVersionFilePath(Path deltaOrBase) 
{
   public static List<FileStatus> getAcidFilesForStats(
       Table table, Path dir, Configuration jc, FileSystem fs) throws 
IOException {
     List<FileStatus> fileList = new ArrayList<>();
-    ValidWriteIdList idList = AcidUtils.getTableValidWriteIdList(jc,
+    org.apache.hadoop.hive.common.ValidWriteIdList idList = 
AcidUtils.getTableValidWriteIdList(jc,
         AcidUtils.getFullTableName(table.getDbName(), table.getTableName()));
     if (idList == null) {
       LOG.warn("Cannot get ACID state for " + table.getDbName() + "." + 
table.getTableName()
-          + " from " + jc.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY));
+          + " from " + 
jc.get(org.apache.hadoop.hive.common.ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY));

Review comment:
       No

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -3148,6 +3175,16 @@ private static void printDirCacheEntries() {
     }
   }
 
+  /**
+   * Checks whether a given table is enabled for replication.
+   * @param tbl table
+   * @return true, if the table is enabled for replication. False, otherwise.
+   */
+  public static boolean inReplication(Table tbl) {
+    return ( tbl != null && tbl.getParameters() != null &&
+     tbl.getParameters().get(ReplicationSpec.KEY.CURR_STATE_ID.toString()) != 
null);
+  }
+

Review comment:
       No




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to