kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r445737751



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -392,7 +395,12 @@ private static Hive getInternal(HiveConf c, boolean 
needsRefresh, boolean isFast
       }
       db = create(c, doRegisterAllFns);
     }
-    if (c != null) {
+    if (c != null && db.conf != null && db.conf != c) {
+      if (db.conf.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY) != null) {
+        c.set(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY, 
db.conf.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY));
+      } else {
+        c.unset(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY);

Review comment:
       I believe this would be required, since we pick ValidWriteIDList from 
the HMS Client, which keeps a copy of Hive.conf. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to