kasakrisz commented on a change in pull request #1437: URL: https://github.com/apache/hive/pull/1437#discussion_r479992802
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java ########## @@ -457,4 +469,17 @@ public boolean hasTableDefined() { return !(aliases.size() == 1 && aliases.get(0).equals(SemanticAnalyzer.DUMMY_TABLE)); } + public void addSubqExprAlias(ASTNode expressionTree, SemanticAnalyzer semanticAnalyzer) throws SemanticException { + String alias = "__subexpr" + subQueryExpressionAliasCounter++; + + // Recursively do the first phase of semantic analysis for the subquery + QBExpr qbexpr = new QBExpr(alias); + + ASTNode subqref = (ASTNode) expressionTree.getChild(1); + semanticAnalyzer.doPhase1QBExpr(subqref, qbexpr, getId(), alias, isInsideView()); Review comment: This step parses the subquery only. It is necessary to collect references to the CTEs in subquery expressions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org