kasakrisz commented on a change in pull request #1437: URL: https://github.com/apache/hive/pull/1437#discussion_r479994280
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java ########## @@ -677,6 +685,33 @@ public void setNoScanAnalyzeCommand(boolean isNoScanAnalyzeCommand) { public boolean hasInsertTables() { return this.insertIntoTables.size() > 0 || this.insertOverwriteTables.size() > 0; } + + public boolean isFullyAggregate() throws SemanticException { Review comment: Added javadocs. I think it can be non-static until it is used from another location. It uses the `destToSelExpr` field located in `QBParseInfo`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org