pvargacl commented on a change in pull request #1501:
URL: https://github.com/apache/hive/pull/1501#discussion_r489214913
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -445,14 +446,23 @@ public static boolean isCompactionTable(Properties
tblProperties) {
}
/**
- * Determine if a table is used during query based compaction.
+ * Determine if a table is used during query based compaction for CRUD
tables.
* @param parameters table properties map
* @return true, if the parameters contains {@link
AcidUtils#COMPACTOR_TABLE_PROPERTY}
*/
public static boolean isCompactionTable(Map<String, String> parameters) {
return Boolean.valueOf(parameters.getOrDefault(COMPACTOR_TABLE_PROPERTY,
"false"));
}
+ /**
+ * Determine if a table is used during query based compaction for MM
insert-only tables.
+ * @param parameters table properties map
+ * @return true, if the parameters contains {@link
AcidUtils#MM_COMPACTOR_TABLE_PROPERTY}
+ */
+ public static boolean isMmCompactionTable(Map<String, String> parameters) {
Review comment:
Shouldn't isCompactionTable return true in both cases? Isn't it a
problem the other places we use this util, that the mmCompactionTable are
missed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
